From 3c0abb05c7ae331d5d8b8b131c9b8602b6ef1e30 Mon Sep 17 00:00:00 2001
From: MattLeo <matt.leo@outlook.com>
Date: Tue, 9 Dec 2025 17:06:07 -0600
Subject: [PATCH] moved app name to localization file

---
 fd-client/.fdk/localstore     |   2 +-
 fd-client/.report.json        | 654 +++++++++++++++++++++++++++-------
 fd-client/app/scripts/app.js  |   2 +-
 fd-client/config/i18n/en.json |   5 +
 fd-client/manifest.json       |   1 -
 5 files changed, 540 insertions(+), 124 deletions(-)
 create mode 100644 fd-client/config/i18n/en.json

diff --git a/fd-client/.fdk/localstore b/fd-client/.fdk/localstore
index 91b5b0e..860ccdb 100644
--- a/fd-client/.fdk/localstore
+++ b/fd-client/.fdk/localstore
@@ -1 +1 @@
-{"fd_cli_101_101_migrate_oauth_status":true,"report_hash":"5571c4887009834af23ecf361d2dbf3ff79c7c7c74499711c1b923a147e0bdc2"}
\ No newline at end of file
+{"fd_cli_101_101_migrate_oauth_status":true,"report_hash":"68e133744a798746add1942f3d4d4e54eafae2ea71b77bc6f83040457d6ee569"}
diff --git a/fd-client/.report.json b/fd-client/.report.json
index 1946a64..517d12d 100644
--- a/fd-client/.report.json
+++ b/fd-client/.report.json
@@ -2,27 +2,17 @@
   "lints": [
     {
       "severity": 1,
-      "value": "app\\scripts\\app.js::6: 'fdClient' declared and assigned in different scopes. Possible asynchronous race condition.",
+      "value": "app\\scripts\\app.js::16: 'currentKA' declared and assigned in different scopes. Possible asynchronous race condition.",
       "type": "custom-js-lint"
     },
     {
       "severity": 1,
-      "value": "app\\scripts\\app.js::11: Expected rejection to be handled.",
+      "value": "app\\scripts\\app.js::40: refrain from simply logging errors.",
       "type": "custom-js-lint"
     },
     {
       "severity": 2,
-      "value": "app\\scripts\\app.js::12: 'ticketData' is defined but never used.",
-      "type": "lint"
-    },
-    {
-      "severity": 1,
-      "value": "app\\scripts\\app.js::17: Expected rejection to be handled.",
-      "type": "custom-js-lint"
-    },
-    {
-      "severity": 1,
-      "value": "app\\scripts\\app.js::18: Too many nested callbacks (5). Maximum allowed is 4.",
+      "value": "app\\scripts\\app.js::59: 'data' is defined but never used.",
       "type": "lint"
     }
   ],
@@ -36,107 +26,297 @@
             "column": 0
           },
           "end": {
-            "line": 31,
+            "line": 77,
             "column": 3
           }
         },
         "1": {
           "start": {
-            "line": 4,
-            "column": 4
+            "line": 2,
+            "column": 20
           },
           "end": {
-            "line": 30,
-            "column": 11
+            "line": 2,
+            "column": 24
           }
         },
         "2": {
           "start": {
-            "line": 6,
-            "column": 12
+            "line": 4,
+            "column": 4
           },
           "end": {
-            "line": 6,
-            "column": 30
+            "line": 4,
+            "column": 40
           }
         },
         "3": {
           "start": {
             "line": 7,
-            "column": 12
+            "column": 4
           },
           "end": {
-            "line": 7,
-            "column": 42
+            "line": 19,
+            "column": 7
           }
         },
         "4": {
           "start": {
-            "line": 9,
-            "column": 12
+            "line": 8,
+            "column": 8
           },
           "end": {
-            "line": 25,
-            "column": 15
+            "line": 8,
+            "column": 67
           }
         },
         "5": {
           "start": {
-            "line": 11,
-            "column": 16
+            "line": 10,
+            "column": 8
           },
           "end": {
-            "line": 24,
-            "column": 23
+            "line": 13,
+            "column": 9
           }
         },
         "6": {
           "start": {
-            "line": 14,
-            "column": 41
+            "line": 11,
+            "column": 12
           },
           "end": {
-            "line": 14,
-            "column": 48
+            "line": 11,
+            "column": 62
           }
         },
         "7": {
           "start": {
-            "line": 17,
-            "column": 24
+            "line": 12,
+            "column": 12
           },
           "end": {
-            "line": 23,
-            "column": 31
+            "line": 12,
+            "column": 19
           }
         },
         "8": {
           "start": {
-            "line": 19,
-            "column": 32
+            "line": 15,
+            "column": 8
           },
           "end": {
-            "line": 22,
-            "column": 35
+            "line": 18,
+            "column": 9
           }
         },
         "9": {
           "start": {
-            "line": 28,
+            "line": 16,
             "column": 12
           },
           "end": {
-            "line": 28,
-            "column": 62
+            "line": 16,
+            "column": 44
           }
         },
         "10": {
           "start": {
-            "line": 29,
+            "line": 17,
             "column": 12
           },
           "end": {
+            "line": 17,
+            "column": 57
+          }
+        },
+        "11": {
+          "start": {
+            "line": 21,
+            "column": 4
+          },
+          "end": {
+            "line": 76,
+            "column": 11
+          }
+        },
+        "12": {
+          "start": {
+            "line": 23,
+            "column": 12
+          },
+          "end": {
+            "line": 23,
+            "column": 46
+          }
+        },
+        "13": {
+          "start": {
+            "line": 26,
+            "column": 12
+          },
+          "end": {
+            "line": 42,
+            "column": 19
+          }
+        },
+        "14": {
+          "start": {
+            "line": 28,
+            "column": 39
+          },
+          "end": {
+            "line": 28,
+            "column": 77
+          }
+        },
+        "15": {
+          "start": {
             "line": 29,
+            "column": 20
+          },
+          "end": {
+            "line": 29,
+            "column": 70
+          }
+        },
+        "16": {
+          "start": {
+            "line": 31,
+            "column": 20
+          },
+          "end": {
+            "line": 38,
+            "column": 21
+          }
+        },
+        "17": {
+          "start": {
+            "line": 33,
+            "column": 39
+          },
+          "end": {
+            "line": 33,
+            "column": 75
+          }
+        },
+        "18": {
+          "start": {
+            "line": 34,
+            "column": 24
+          },
+          "end": {
+            "line": 37,
+            "column": 48
+          }
+        },
+        "19": {
+          "start": {
+            "line": 41,
+            "column": 20
+          },
+          "end": {
+            "line": 41,
+            "column": 66
+          }
+        },
+        "20": {
+          "start": {
+            "line": 44,
+            "column": 12
+          },
+          "end": {
+            "line": 71,
+            "column": 15
+          }
+        },
+        "21": {
+          "start": {
+            "line": 45,
+            "column": 16
+          },
+          "end": {
+            "line": 45,
+            "column": 76
+          }
+        },
+        "22": {
+          "start": {
+            "line": 47,
+            "column": 16
+          },
+          "end": {
+            "line": 53,
+            "column": 17
+          }
+        },
+        "23": {
+          "start": {
+            "line": 48,
+            "column": 20
+          },
+          "end": {
+            "line": 51,
+            "column": 23
+          }
+        },
+        "24": {
+          "start": {
+            "line": 52,
+            "column": 20
+          },
+          "end": {
+            "line": 52,
+            "column": 27
+          }
+        },
+        "25": {
+          "start": {
+            "line": 55,
+            "column": 16
+          },
+          "end": {
+            "line": 70,
+            "column": 23
+          }
+        },
+        "26": {
+          "start": {
+            "line": 60,
+            "column": 24
+          },
+          "end": {
+            "line": 63,
+            "column": 27
+          }
+        },
+        "27": {
+          "start": {
+            "line": 66,
+            "column": 24
+          },
+          "end": {
+            "line": 69,
+            "column": 27
+          }
+        },
+        "28": {
+          "start": {
+            "line": 74,
+            "column": 12
+          },
+          "end": {
+            "line": 74,
+            "column": 62
+          }
+        },
+        "29": {
+          "start": {
+            "line": 75,
+            "column": 12
+          },
+          "end": {
+            "line": 75,
             "column": 83
           }
         }
@@ -160,7 +340,7 @@
               "column": 58
             },
             "end": {
-              "line": 31,
+              "line": 77,
               "column": 1
             }
           },
@@ -170,174 +350,406 @@
           "name": "(anonymous_1)",
           "decl": {
             "start": {
-              "line": 5,
-              "column": 14
+              "line": 7,
+              "column": 39
             },
             "end": {
-              "line": 5,
-              "column": 15
+              "line": 7,
+              "column": 40
             }
           },
           "loc": {
             "start": {
-              "line": 5,
-              "column": 32
+              "line": 7,
+              "column": 55
             },
             "end": {
-              "line": 26,
-              "column": 9
+              "line": 19,
+              "column": 5
             }
           },
-          "line": 5
+          "line": 7
         },
         "2": {
           "name": "(anonymous_2)",
           "decl": {
             "start": {
-              "line": 9,
-              "column": 79
+              "line": 22,
+              "column": 14
             },
             "end": {
-              "line": 9,
-              "column": 80
+              "line": 22,
+              "column": 15
             }
           },
           "loc": {
             "start": {
-              "line": 9,
-              "column": 90
+              "line": 22,
+              "column": 32
             },
             "end": {
-              "line": 25,
-              "column": 13
+              "line": 72,
+              "column": 9
             }
           },
-          "line": 9
+          "line": 22
         },
         "3": {
           "name": "(anonymous_3)",
           "decl": {
             "start": {
-              "line": 12,
-              "column": 26
+              "line": 27,
+              "column": 22
             },
             "end": {
-              "line": 12,
-              "column": 27
+              "line": 27,
+              "column": 23
             }
           },
           "loc": {
             "start": {
-              "line": 12,
-              "column": 47
+              "line": 27,
+              "column": 37
             },
             "end": {
-              "line": 24,
-              "column": 21
+              "line": 39,
+              "column": 17
             }
           },
-          "line": 12
+          "line": 27
         },
         "4": {
           "name": "(anonymous_4)",
           "decl": {
             "start": {
-              "line": 18,
-              "column": 34
+              "line": 40,
+              "column": 23
             },
             "end": {
-              "line": 18,
-              "column": 35
+              "line": 40,
+              "column": 24
             }
           },
           "loc": {
             "start": {
-              "line": 18,
-              "column": 45
+              "line": 40,
+              "column": 39
             },
             "end": {
-              "line": 23,
-              "column": 29
+              "line": 42,
+              "column": 17
             }
           },
-          "line": 18
+          "line": 40
         },
         "5": {
           "name": "(anonymous_5)",
           "decl": {
             "start": {
-              "line": 27,
+              "line": 44,
+              "column": 79
+            },
+            "end": {
+              "line": 44,
+              "column": 80
+            }
+          },
+          "loc": {
+            "start": {
+              "line": 44,
+              "column": 90
+            },
+            "end": {
+              "line": 71,
+              "column": 13
+            }
+          },
+          "line": 44
+        },
+        "6": {
+          "name": "(anonymous_6)",
+          "decl": {
+            "start": {
+              "line": 59,
+              "column": 26
+            },
+            "end": {
+              "line": 59,
+              "column": 27
+            }
+          },
+          "loc": {
+            "start": {
+              "line": 59,
+              "column": 41
+            },
+            "end": {
+              "line": 64,
+              "column": 21
+            }
+          },
+          "line": 59
+        },
+        "7": {
+          "name": "(anonymous_7)",
+          "decl": {
+            "start": {
+              "line": 65,
+              "column": 27
+            },
+            "end": {
+              "line": 65,
+              "column": 28
+            }
+          },
+          "loc": {
+            "start": {
+              "line": 65,
+              "column": 43
+            },
+            "end": {
+              "line": 70,
+              "column": 21
+            }
+          },
+          "line": 65
+        },
+        "8": {
+          "name": "(anonymous_8)",
+          "decl": {
+            "start": {
+              "line": 73,
               "column": 15
             },
             "end": {
-              "line": 27,
+              "line": 73,
               "column": 16
             }
           },
           "loc": {
             "start": {
-              "line": 27,
+              "line": 73,
               "column": 31
             },
             "end": {
-              "line": 30,
+              "line": 76,
               "column": 9
             }
           },
-          "line": 27
+          "line": 73
+        }
+      },
+      "branchMap": {
+        "0": {
+          "loc": {
+            "start": {
+              "line": 10,
+              "column": 8
+            },
+            "end": {
+              "line": 13,
+              "column": 9
+            }
+          },
+          "type": "if",
+          "locations": [
+            {
+              "start": {
+                "line": 10,
+                "column": 8
+              },
+              "end": {
+                "line": 13,
+                "column": 9
+              }
+            },
+            {
+              "start": {},
+              "end": {}
+            }
+          ],
+          "line": 10
+        },
+        "1": {
+          "loc": {
+            "start": {
+              "line": 15,
+              "column": 8
+            },
+            "end": {
+              "line": 18,
+              "column": 9
+            }
+          },
+          "type": "if",
+          "locations": [
+            {
+              "start": {
+                "line": 15,
+                "column": 8
+              },
+              "end": {
+                "line": 18,
+                "column": 9
+              }
+            },
+            {
+              "start": {},
+              "end": {}
+            }
+          ],
+          "line": 15
+        },
+        "2": {
+          "loc": {
+            "start": {
+              "line": 31,
+              "column": 20
+            },
+            "end": {
+              "line": 38,
+              "column": 21
+            }
+          },
+          "type": "if",
+          "locations": [
+            {
+              "start": {
+                "line": 31,
+                "column": 20
+              },
+              "end": {
+                "line": 38,
+                "column": 21
+              }
+            },
+            {
+              "start": {},
+              "end": {}
+            }
+          ],
+          "line": 31
+        },
+        "3": {
+          "loc": {
+            "start": {
+              "line": 47,
+              "column": 16
+            },
+            "end": {
+              "line": 53,
+              "column": 17
+            }
+          },
+          "type": "if",
+          "locations": [
+            {
+              "start": {
+                "line": 47,
+                "column": 16
+              },
+              "end": {
+                "line": 53,
+                "column": 17
+              }
+            },
+            {
+              "start": {},
+              "end": {}
+            }
+          ],
+          "line": 47
         }
       },
-      "branchMap": {},
       "s": {
-        "0": 2,
-        "1": 2,
-        "2": 2,
-        "3": 2,
-        "4": 2,
-        "5": 1,
-        "6": 1,
-        "7": 1,
-        "8": 0,
-        "9": 0,
-        "10": 0
+        "0": 13,
+        "1": 13,
+        "2": 13,
+        "3": 13,
+        "4": 35,
+        "5": 35,
+        "6": 26,
+        "7": 26,
+        "8": 9,
+        "9": 9,
+        "10": 9,
+        "11": 13,
+        "12": 13,
+        "13": 13,
+        "14": 13,
+        "15": 13,
+        "16": 13,
+        "17": 6,
+        "18": 6,
+        "19": 0,
+        "20": 13,
+        "21": 2,
+        "22": 2,
+        "23": 0,
+        "24": 0,
+        "25": 2,
+        "26": 2,
+        "27": 0,
+        "28": 0,
+        "29": 0
       },
       "f": {
-        "0": 2,
-        "1": 2,
-        "2": 1,
-        "3": 1,
+        "0": 13,
+        "1": 35,
+        "2": 13,
+        "3": 13,
         "4": 0,
-        "5": 0
+        "5": 2,
+        "6": 2,
+        "7": 0,
+        "8": 0
+      },
+      "b": {
+        "0": [
+          26,
+          9
+        ],
+        "1": [
+          9,
+          0
+        ],
+        "2": [
+          6,
+          7
+        ],
+        "3": [
+          0,
+          2
+        ]
       },
-      "b": {},
       "_coverageSchema": "1a1c01bbd47fc00a2c39e90264f33305004495a9",
-      "hash": "be7a4d54242fcac22528119b05a9a5cae58c3b78"
+      "hash": "b15f7d260a11f1649b19a5f5d29df6f8aaa4bc2e"
     }
   },
   "coverageSummary": {
     "lines": {
-      "total": 11,
-      "covered": 8,
+      "total": 30,
+      "covered": 24,
       "skipped": 0,
-      "pct": 72.72
+      "pct": 80
     },
     "statements": {
-      "total": 11,
-      "covered": 8,
+      "total": 30,
+      "covered": 24,
       "skipped": 0,
-      "pct": 72.72
+      "pct": 80
     },
     "functions": {
-      "total": 6,
-      "covered": 4,
+      "total": 9,
+      "covered": 6,
       "skipped": 0,
       "pct": 66.66
     },
     "branches": {
-      "total": 0,
-      "covered": 0,
+      "total": 8,
+      "covered": 6,
       "skipped": 0,
-      "pct": 100
+      "pct": 75
     }
   }
 }
diff --git a/fd-client/app/scripts/app.js b/fd-client/app/scripts/app.js
index a23dd7a..d3fba00 100644
--- a/fd-client/app/scripts/app.js
+++ b/fd-client/app/scripts/app.js
@@ -56,7 +56,7 @@ document.addEventListener('DOMContentLoaded', function () {
                     id: "cf_ka_number",
                     value: currentKA
                 })
-                    .then(function(data) {
+                    .then(function(_data) {
                         return client.interface.trigger('showNotify', {
                             type: 'success',
                             message: currentKA + ' attached to ticket'
diff --git a/fd-client/config/i18n/en.json b/fd-client/config/i18n/en.json
new file mode 100644
index 0000000..c7cf3a6
--- /dev/null
+++ b/fd-client/config/i18n/en.json
@@ -0,0 +1,5 @@
+{
+  "app": {
+    "name": "Cram-A-Lot Knowledge Base"
+  }
+}
\ No newline at end of file
diff --git a/fd-client/manifest.json b/fd-client/manifest.json
index b17f434..ca2ea19 100644
--- a/fd-client/manifest.json
+++ b/fd-client/manifest.json
@@ -1,6 +1,5 @@
 {
   "platform-version": "3.0",
-  "name": "Cram-A-Lot Knowledge Base",
   "modules": {
     "support_ticket": {
       "location": {